fix: Allow changes to "runner_worker.max_jobs" for Docker Autoscaler #1221
Conversation
Remove ignore_changes from the ASG for Docker Autoscaler. The reasoning described in the comment was poor; min_size and desired_capacity are fixed at zero, so won't change, and max_size should change when runner_worker.max_jobs is changed, and will not cause immediate scale-up. If it causes scale-down, this the logical desired behaviour.
|
Hey @jonmcewen! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
jonmcewen
changed the title
|
Just wondering why an ignore changes on |
That came into my mind too. |
| ignore_changes = [ | ||
| desired_capacity, | ||
| min_size, | ||
| max_size | ||
| ] |
There was a problem hiding this comment.
question: As far as I remember, these values are managed by the autoscaler and shouldn't be touched by us later.
Description
Remove ignore_changes from the ASG for Docker Autoscaler. The reasoning described in the comment was poor; min_size and desired_capacity are fixed at zero, so won't change, and max_size should change when runner_worker.max_jobs is changed, and will not cause immediate scale-up. If it causes scale-down, this the logical desired behaviour.
Migrations required
No
Verification
Tested by changing runner_worker.max_jobs on an existing runner.